Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tip pointing to code splitting #4236

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Add a tip pointing to code splitting #4236

merged 4 commits into from
Dec 15, 2021

Conversation

Faithfinder
Copy link
Contributor


name: 📖 Add a tip pointing to code splitting
about: Updating content in an existing docs page

PR Type

update an existing page

Checklist

  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
    • No, since I've edited directly in Github, but LGTM?

What docs page is being added or updated?

  • Section: Redux Essentials
  • Page: RTK Query Advanced Patterns

For Updating Existing Content

What updates should be made to the page?

The main goal is to highlight the fact that you're expect to have only one createApi call in the app. (Maybe it's rather one per API, as in, if it's a different server, it's a different createApi?). I'm also putting a link to the advanced concept of Injecting endpoints that people most likely want when calling createApi multiple times.

Do these updates change any of the assumptions or target audience? If so, how do they change?

I don't think so.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19bdb1c:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: 19bdb1c

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/61b966a2901b6400078ff49d

😎 Browse the preview: https://deploy-preview-4236--redux-docs.netlify.app

@markerikson
Copy link
Contributor

Thanks!

@markerikson markerikson merged commit c77c3c5 into reduxjs:master Dec 15, 2021
@Faithfinder Faithfinder deleted the patch-1 branch December 15, 2021 13:34
nevilm-lt pushed a commit to nevilm-lt/redux that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants