Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS definitions test for new Dispatch typing #2674

Merged
merged 2 commits into from
Oct 23, 2017

Conversation

pelotom
Copy link
Contributor

@pelotom pelotom commented Oct 22, 2017

No description provided.

@timdorr
Copy link
Member

timdorr commented Oct 22, 2017

BTW, there is another PR (#2671, that I busted with next updates just now), that has a similar, but different set of fixes: b9278d1

Any thoughts on the comparison between the two?

@pelotom
Copy link
Contributor Author

pelotom commented Oct 23, 2017

By and large it's equivalent, but these definitions aren't quite right:

// dispatch.ts
declare module "../../" {
  export interface Dispatch<D = Action> {
    <R>(asyncAction: (dispatch: Dispatch<D>, getState: () => D) => R): R;
    // ^ `getState()` should not return the action type `D`
  }
}
// middleware.ts
declare module "../../" {
    export interface Dispatch<D> {
        <R,S>(asyncAction: (dispatch: Dispatch<D>, getState: () => S) => R): R;
        // ^ `getState()` should not be parameterized by the state type `S`; the type
        // of the state is not determined by the caller
    }
}

@timdorr
Copy link
Member

timdorr commented Oct 23, 2017

Thanks. I'm starting to get my bearings with TS stuff, but our typings are really dense and I need some hand-holding :)

I think this looks good. Since we're now passing, this should get my other PRs unblocked. Thank you!

@timdorr timdorr merged commit fc0d7ae into reduxjs:next Oct 23, 2017
@pelotom pelotom deleted the fix-ts-definitions-test branch October 23, 2017 00:13
@pelotom
Copy link
Contributor Author

pelotom commented Oct 23, 2017

No problem, looking forward to seeing these typings on master!

timdorr pushed a commit that referenced this pull request Oct 23, 2017
* Fix TypeScript definitions test for new Dispatch typing

* Be explicit about type parameters
timdorr pushed a commit that referenced this pull request Nov 3, 2017
* Fix TypeScript definitions test for new Dispatch typing

* Be explicit about type parameters
timdorr pushed a commit that referenced this pull request Nov 16, 2017
* Fix TypeScript definitions test for new Dispatch typing

* Be explicit about type parameters
seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
* Fix TypeScript definitions test for new Dispatch typing

* Be explicit about type parameters
tomipaul pushed a commit to tomipaul/redux that referenced this pull request Apr 8, 2018
* Fix TypeScript definitions test for new Dispatch typing

* Be explicit about type parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants