Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type helpers for OnQueryStarted callbacks #4713

Merged
merged 7 commits into from
Nov 23, 2024

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59 aryaemami59 commented Nov 13, 2024

This PR:

Copy link

codesandbox bot commented Nov 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 602cd20
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6742330aa3f5510008ef3d27
😎 Deploy Preview https://deploy-preview-4713--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Nov 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 602cd20:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@aryaemami59 aryaemami59 marked this pull request as ready for review November 13, 2024 18:05
@EskiMojo14
Copy link
Collaborator

code wise this looks good - i'm still iffy on the name so may take a few to mull it over

@markerikson markerikson changed the title Add the TypedOnQueryStartedForQueryEndpoints and TypedOnQueryStartedForMutationEndpoints type helpers Add type helpers for OnQueryStarted callbacks Nov 23, 2024
@markerikson
Copy link
Collaborator

Per chat, shortening these to Typed[Query|Mutation]OnQueryStarted

@markerikson markerikson merged commit fe2d181 into reduxjs:master Nov 23, 2024
43 checks passed
@markerikson markerikson deleted the Typed-onQueryStarted branch November 23, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTK Query 2.0 Migration: Typing onQueryStarted without LifecycleApi types
3 participants