Rewrite RTKQ internal subscription lookups and subscription syncing #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `subscriptionUpdated` from a microtask to a 500ms throttle - Exposed the RTKQ internal middleware state to be returned via an internal action, so that hooks can read that state directly without needing to call `dispatch()` on every render. - Reworked tests to completely ignore `subscriptionsUpdated` in any action sequence checks due to timing changes and irrelevance - Fixed case where `invalidateTags` was still reading from store state
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
markerikson
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0c3869:
|
phryneas
reviewed
Oct 26, 2023
| @@ -681,6 +682,27 @@ export function buildHooks<Definitions extends EndpointDefinitions>({ | |||
| Definitions | |||
| > | |||
| const dispatch = useDispatch<ThunkDispatch<any, any, UnknownAction>>() | |||
| const internalStateRef = useRef<InternalMiddlewareState | null>(null) | |||
There was a problem hiding this comment.
This logic in the hooks file hurts a bit. Maybe the middleware could return a hasSubscription function instead of the internal state itself?
phryneas
reviewed
Oct 26, 2023
Comment on lines
+76
to
+77
| const subscriptionSubState = | ||
| internalState.currentSubscriptions[queryCacheKey] ?? {} |
There was a problem hiding this comment.
Thank you for catching this one!
markerikson
force-pushed
the
feature/3709-alter-subscription-updates
branch
from
2fc1ee6 to
e0c3869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscriptionUpdatedfrom a microtask to a 500ms throttleExposed the RTKQ internal middleware state to be returned via aninternal action, so that hooks can read that state directly without
needing to call
dispatch()on every render.Updated the
batchActionsmiddleware to return aSubscriptionSelectorsobject with{getSubscriptions, getSubscriptionCount, isRequestSubscribed}, and used that in the hook (and tests)subscriptionsUpdatedin anyaction sequence checks due to timing changes and irrelevance
invalidateTagswas still reading from store state