Fixed Stackoverflow bug if children prop is a ref to root/parent object

[cheprasov]

Fixed Stackoverflow bug if children prop is a ref to root/parent object

Fixed Bug:
RangeError: Maximum call stack size exceeded at trackProperties (.../node_modules/@reduxjs/toolkit/dist/redux-toolkit.cjs.development.js:322:25)

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58476a0:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration
rsk-github-issues-example	Configuration
@examples-query-react/basic	Configuration
@examples-query-react/advanced	Configuration
@examples-action-listener/counter	Configuration

[netlify]

✅ Deploy Preview for redux-starter-kit-docs ready!

Name	Link
🔨 Latest commit	58476a0
🔍 Latest deploy log	https://app.netlify.com/sites/redux-starter-kit-docs/deploys/64596d5c2cc99b0008e5975c
😎 Deploy Preview	https://deploy-preview-3428--redux-starter-kit-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[markerikson]

@cheprasov Interesting, thanks. Two questions:

• Can you add a new unit test that checks this case?
• What scenario happened that led you to finding this? Normally I would not expect the same object reference to appear in multiple places in a state tree.

[cheprasov]

@cheprasov Interesting, thanks. Two questions:

Hi @markerikson
Thanks a lot.

• Can you add a new unit test that checks this case?

• Unfortunately, I do not have enough time for writing the tests. I just copied the fix from my project.

• What scenario happened that led you to finding this? Normally I would not expect the same object reference to appear in multiple places in a state tree.
  I did complex thing, but will try to explain simple way. I added to the state Express Response object that has a lot of child props with ref to some parents objects.

I really need the fix in my project, it allows me to use Redux state for more complex things :)

[markerikson]

@cheprasov : I hate to say it, but that sounds like a misuse of Redux.

It's fine to use Redux on the server. But, a Redux store really should only have plain non-serializable data inside, and an Express Response object is definitely not "plain data":

• https://redux.js.org/style-guide/#do-not-put-non-serializable-values-in-state-or-actions

If you are really going to do that, I'd suggest just turning off this middleware during store setup.

[cheprasov]

@cheprasov : I hate to say it, but that sounds like a misuse of Redux.

It's fine to use Redux on the server. But, a Redux store really should only have plain non-serializable data inside, and an Express Response object is definitely not "plain data":

• https://redux.js.org/style-guide/#do-not-put-non-serializable-values-in-state-or-actions

If you are really going to do that, I'd suggest just turning off this middleware during store setup.

Yep, thanks a lot. I have disabled serialization already.

[markerikson]

That said, the tweak here doesn't hurt, so I'll go ahead and merge it. Thanks!