Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON detection #2329

Closed
wants to merge 7 commits into from
Closed

Improve JSON detection #2329

wants to merge 7 commits into from

Conversation

ShaunDychko
Copy link
Contributor

Resolves #2282

@netlify
Copy link

netlify bot commented May 15, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 2e295bb
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6281441878f2510008d185bd
😎 Deploy Preview https://deploy-preview-2329--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e295bb:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
reduxjs/redux-toolkit Configuration

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not 100% sure if we generally can do this, but this would be shorter.

packages/toolkit/src/query/fetchBaseQuery.ts Outdated Show resolved Hide resolved
@phryneas
Copy link
Member

phryneas commented Jul 3, 2022

This is already handled over in #2331

@phryneas phryneas closed this Jul 3, 2022
@ShaunDychko ShaunDychko deleted the improve-json-detection branch July 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve fetchBaseQuery content json verification
2 participants