Update mergeProps to optionally accept a factory style function#523

Closed

neeharv wants to merge 101 commits intoreduxjs:masterfrom neeharv:next

+55-2

Commits on Aug 15, 2016

Remove Style section
timdorr
authored

Commits on Feb 18, 2017

Reimplementing connect() and extracting connectToStore() based on 'reselect'. (6 failing tests to go)

jimbolla
authored and
neeharv
committed
Changes to fix failing tests (4 fails to go)

jimbolla
authored and
neeharv
committed
Change code to make tests for factory mapStateToProps/mapDispatchToProps pass. BREAKING CHANGE: requires setting an option parameter mapStateIsFactory/mapDispatchIsFactory to signal factory methods.

jimbolla
authored and
neeharv
committed
Adjust remaining 2 failing tests to account for slightly different behind-the-scenes behavior of new implementation.

jimbolla
authored and
neeharv
committed
add dispatchable to the exported functions

jimbolla
authored and
neeharv
committed
Replace string ref with function ref. Adjust test to match

jimbolla
authored and
neeharv
committed
Generalized a couple error messages

jimbolla
authored and
neeharv
committed
make additional options passed to connect() fall through to connectToStore()

jimbolla
authored and
neeharv
committed
rename connectToStore to connectAdvanced

jimbolla
authored and
neeharv
committed
pull some utility functions out of connectAdvanced into their own utils files

jimbolla
authored and
neeharv
committed
refactor connect + connectAdvanced

jimbolla
authored and
neeharv
committed
remove dispatchable()... this probably doesn't need to be a part of react-redux.

jimbolla
authored and
neeharv
committed
remove unneeded selector value on unmount

jimbolla
authored and
neeharv
committed
avoid excess verify() when using defaultMergeProps

jimbolla
authored and
neeharv
committed
pull buildSelector out of connectAdvanced... less function nesting

jimbolla
authored and
neeharv
committed
refactor connect() selector builders

jimbolla
authored and
neeharv
committed
remove need for explicit factory flags

jimbolla
authored and
neeharv
committed
don't do shape verification in production ENV

jimbolla
authored and
neeharv
committed
refactor to split init from trySubscribe

jimbolla
authored and
neeharv
committed
Move subscribe from willMount to didMount to avoid serverside memory leaks

jimbolla
authored and
neeharv
committed
Remove extra createShallowEqualSelector file since it's not adding much value

jimbolla
authored and
neeharv
committed
move ref/recomputationsProp setters into buildSelector... simplify render()

jimbolla
authored and
neeharv
committed
refactor + comment advancedConnect

jimbolla
authored and
neeharv
committed
pull buildSelector func into own file

jimbolla
authored and
neeharv
committed
Make buildSelector injectable into connectAdvanced as another option

jimbolla
authored and
neeharv
committed
refactor+comment connect.js

jimbolla
authored and
neeharv
committed
Change the way nested connected components subscribe so that parent components always subscribe before child components, so that parents always update before children.

jimbolla
authored and
neeharv
committed
Fix failing tests. Change the way nested components subscribe... instead of subscribing to the store directly they subscribe via their ancestor connected component. This ensures the ancestor gets t…

jimbolla
authored and
neeharv
committed
ensure nested subs are notified properly

jimbolla
authored and
neeharv
committed
Eliminate extraneous tracking of recomputations count since we can just compare last rendered props to new selected props

jimbolla
authored and
neeharv
committed
simplify nested subs code. no need for extra object wrappers

jimbolla
authored and
neeharv
committed
rename shouldUseState to dependsOnState to make its meaning more clear

jimbolla
authored and
neeharv
committed
prebind notifyNestedSubs to avoid extra lambda func

jimbolla
authored and
neeharv
committed
Add WrappedComponent as one of the option params passed to buildSelector(). Useful if one wanted to build a selector from the component's attributes, such as its propTypes, for example.

jimbolla
authored and
neeharv
committed
Extract Subscription class from connectAdvanced

jimbolla
authored and
neeharv
committed
Replace reselect with manual memoization in buildSelector. Faster!

jimbolla
authored and
neeharv
committed
refactor buildSelector

jimbolla
authored and
neeharv
committed
refactor connect()... extract selectors, replace reselect with hand-rolled memoization

jimbolla
authored and
neeharv
committed
Re-add isSubscribed() to reduce test delta

jimbolla
authored and
neeharv
committed
refactor buildFactoryAwareSelector and remove extraneous selector index file

jimbolla
authored and
neeharv
committed
improve memoization perf

jimbolla
authored and
neeharv
committed
refactor connect + selectors for clarity

jimbolla
authored and
neeharv
committed
refactor connect + selectors

jimbolla
authored and
neeharv
committed
pull apart buildSelector into its pieces and move them into getFinalProps and connectAdvanced because it wasn't clear what it did as it was

jimbolla
authored and
neeharv
committed
Move where 'extra props' (ref and recomputations) are added to the final props to simplify memoization functions

jimbolla
authored and
neeharv
committed
Refactor props memoization

jimbolla
authored and
neeharv
committed
Move ownProps memoization into connectAdvanced to simplify selectors.

jimbolla
authored and
neeharv
committed
utilize memoizeProps in createFactoryAwareSelector

jimbolla
authored and
neeharv
committed
rename recomputations to renderCount to make its intent clearer

jimbolla
authored and
neeharv
committed
refactoring selectors + connect for clarity

jimbolla
authored and
neeharv
committed
Hide connectAdvanced and advancedOptions

jimbolla
authored and
neeharv
committed
fix nits

jimbolla
authored and
neeharv
committed
fix messed up path

jimbolla
authored and
neeharv
committed
Add guard for the case of a component causing its siblings to unsubscribe in the middle of the notification loop.

jimbolla
authored and
neeharv
committed
Add comments to connect.js

jimbolla
authored and
neeharv
committed
refactoring + some perf opimizations

jimbolla
authored and
neeharv
committed
refactoring+comments for clarity

jimbolla
authored and
neeharv
committed
refactoring

jimbolla
authored and
neeharv
committed
Optimize Subscription subscribe/unsubscribe

jimbolla
authored and
neeharv
committed
comments

jimbolla
authored and
neeharv
committed
refactor selectors

jimbolla
authored and
neeharv
committed
rename files

jimbolla
authored and
neeharv
committed
Change Subscription to follow same subscribe/unsubscribe/notify mechanics as redux's createStore

jimbolla
authored and
neeharv
committed
refactoring connect's selectors to move logic to determine what to recompute into getFinalProps.js

jimbolla
authored and
neeharv
committed
refactoring/optimizing connect+selectors

jimbolla
authored and
neeharv
committed
refactoring/optimizing connect+selectors

jimbolla
authored and
neeharv
committed
Merge selectors and connect.js into a connect folder

jimbolla
authored and
neeharv
committed
comments

jimbolla
authored and
neeharv
committed
refactoring connect

jimbolla
authored and
neeharv
committed
Optimize connectAdvanced to not create subscription if it shouldn't respond to state changes.

jimbolla
authored and
neeharv
committed
Refactor - put dependsOnOwnProps right on the selector func instead of extra "meta" property

jimbolla
authored and
neeharv
committed
Add test from reduxjs#293 and uncomment now-passing expect in 'should pass state consistently to mapState'

jimbolla
authored and
neeharv
committed
Added passing test from reduxjs#395

jimbolla
authored and
neeharv
committed
Add passing test from reduxjs#429

jimbolla
authored and
neeharv
committed
Add code + test for reduxjs#436

jimbolla
authored and
neeharv
committed
Extract buildConnectOptions out of connect()... will make testing easier

jimbolla
authored and
neeharv
committed
Remove eslint-config-rackt.

timdorr
authored and
neeharv
committed
isparta is dead. And use Codecov.

timdorr
authored and
neeharv
committed
bind proper store context in connectAdvanced and the Subscription util

vhmth
authored and
neeharv
committed
add store context-preservation tests

vhmth
authored and
neeharv
committed
tests and fixes reduxjs#457

jimbolla
authored and
neeharv
committed
refactors out count variable in Subscription.js

jimbolla
authored and
neeharv
committed
refactors subscription to be slightly clearer

jimbolla
authored and
neeharv
committed
exposes new features to the API

jimbolla
authored and
neeharv
committed
Add es2015 modules export from redux project (reduxjs#501 )

btd
authored and
neeharv
committed
Set displayName explicitly on Provider (reduxjs#506 )

roncohen
authored and
neeharv
committed
warn on duplicate props (reduxjs#508 )

ynonp
authored and
neeharv
committed
Update API docs for v5 (reduxjs#480 )

jimbolla
authored and
neeharv
committed
groups factories options and move *areEqual defaults into connect (reduxjs#477 )

jimbolla
authored and
neeharv
committed
Whoops, didn't bump the version in git...

timdorr
authored and
neeharv
committed
5.0.0-beta.2

timdorr
authored and
neeharv
committed
Revert "warn on duplicate props" (reduxjs#511 )

timdorr
authored and
neeharv
committed
5.0.0-beta.3

timdorr
authored and
neeharv
committed
Supress eslint error "react/display-name" at intentional omission.

jimbolla
authored and
neeharv
committed
Fix error from clear() called during notify() (reduxjs#517 )

appden
authored and
neeharv
committed
Update mergeProps to optionally accept a factory style function
neeharv
committed
reuse the factory function if passed for mergeProps
neeharv
committed
update test for mergePropFactory fn
neeharv
committed
Merge remote-tracking branch 'upstream/master' into next
neeharv
committed
update docs
neeharv
committed