Rethrowing original errors thrown in selector functions #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When throwing error from selector function, append original error stacktrace (if present) to new error.
|
Deploy preview for react-redux-docs ready! Built with commit f310d64 |
|
No, the issue we have is that we catch one error and throw a different error. My suggestion is probably the way to go here. |
r3dm1ke
changed the title
|
Cool, thanks for putting this together! |
This was referenced Mar 8, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 9, 2020
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* Added optional stacktrace to errors thrown from selector functions When throwing error from selector function, append original error stacktrace (if present) to new error. * Rethrowing original errors from selector functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When throwing error from selector function, append original error stacktrace (if present) to new error. Should fix #1433