Remove invariant in favor of doing NODE_ENV checks directly #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 0dbb654 |
|
Thanks! |
This was referenced Mar 8, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 9, 2020
This was referenced Apr 28, 2020
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1470
Removes tiny (but distributes solely in CJS format and thus deoptimizing) dependency. It also follows suit of facebook/react#16753 - this should be more approachable to newcomers, because
invariantis a little bit quirky - in example I often found myself wondering if I should use passing or failing condition when working with various OSS projects using this pattern. This change makes it easier to immediately know how this works.This only helps webpack as Rollup is smart enough to remove this dependency on its own. Results on my playground:
Rolluped: 3330 Rolluped & uglified: 2388 Webpacked: - 3294 + 3071