Support server rendering with window polyfill #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on server or not
|
Deploy preview for react-redux-docs ready! Built with commit 7ac0442 |
|
Thanks! |
|
Ooooo, nice! Thanks! |
|
Is this logic correct when using react-redux in React Native? window.document and window.document.createElement do not exist there but we should still use useLayoutEffect. It's also inconsistent with the useIsomorphicLayoutEffect logic in useSelector |
This was referenced Nov 4, 2019
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
…ng on server or not (reduxjs#1283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React warns about using useLayoutEffect during server rendering if window has been polyfilled since only the existence of window is checked in connectAdvanced.js
I suggest using the same check that React has in ExecutionEnvironment.js.