Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timing issue in component updates due to consecutive dispatches #1263

Merged
merged 1 commit into from
Apr 26, 2019
Merged

fix timing issue in component updates due to consecutive dispatches #1263

merged 1 commit into from
Apr 26, 2019

Conversation

MrWolfZ
Copy link
Contributor

@MrWolfZ MrWolfZ commented Apr 26, 2019

This PR fixes #1262 and should hopefully fix the problems described in #1226 as well.

@netlify
Copy link

netlify bot commented Apr 26, 2019

Deploy preview for react-redux-docs ready!

Built with commit 622545d

https://deploy-preview-1263--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Apr 26, 2019

LGTM

@timdorr timdorr merged commit d162625 into reduxjs:master Apr 26, 2019
@markerikson
Copy link
Contributor

Well, that was all kinds of fun.

@MrWolfZ : thanks for digging in to this one!

@markerikson
Copy link
Contributor

Whoops, looks like this one went into master instead of v7-hooks-alpha.

I'll revert, figure out how to pull it into the alpha branch, then publish this as 7.1.0-alpha.2.

markerikson added a commit that referenced this pull request Apr 28, 2019
@markerikson
Revert "fix timing issue in component updates due to consecutive disp…
9a7dacc 
…atches (#1263)"

This reverts commit d162625.
@markerikson markerikson mentioned this pull request Apr 28, 2019
Merged
markerikson added a commit that referenced this pull request Apr 28, 2019
@markerikson
Revert "fix timing issue in component updates due to consecutive disp…
bfab97b 
…atches (#1263)" (#1264)

This reverts commit d162625.
@MrWolfZ
Copy link
Contributor Author

MrWolfZ commented Apr 28, 2019

@markerikson I don't understand. This fix has nothing to do with the hooks alpha. It's a fix for the existing connect API and I expected this to be released as 7.0.3.

@markerikson
Copy link
Contributor

Drat. Y'know what, you're right. I misread this. Sorry, my bad.

I'll get this back in and put out 7.0.3 shortly.

@markerikson
Copy link
Contributor

Reset master to remove that reversion and force-pushed. (Wheeee!)

@markerikson
Copy link
Contributor

And 7.0.3 is out on NPM. Sorry about that, and thanks for catching my mistake!

@MrWolfZ MrWolfZ deleted the issue-1262 branch April 30, 2019 07:19
@reduxjs reduxjs deleted a comment from TimSusa Apr 30, 2019
@Andrekra
Copy link

Andrekra commented May 1, 2019

Thanks! This resolved our issues with 7.0.2

@ykagan ykagan mentioned this pull request Sep 12, 2019
Closed
This was referenced Oct 26, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
@MrWolfZ @timdorr
fix timing issue in component updates due to consecutive dispatches (r…
7da000b 
…eduxjs#1263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consecutive dispatches can lead to incorrect update order
4 participants
@MrWolfZ @timdorr @markerikson @Andrekra