Updated: Support React-Hot-Loader compatibility #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runner script tried to pass the Jest config as stringified JSON, but that was breaking for me somehow. Sidestepped the problem by writing the settings to disk instead and pointing Jest to that file.
|
Deploy preview for react-redux-docs ready! Built with commit d78dd73 |
|
And merging. |
|
@timdorr : might as well go ahead and put out 6.0.1 with this and the "is it a real context?" change. |
|
👍 |
|
Thank you! |
|
💯 to 6.0.1 |
|
Looks like react-redux 7.0.0 causes connected components to not load when used with react-hot-loader. Should that be filed as a separate ticket or should this one be re-opened? |
|
Please update |
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* fix: react-hot-loader compatibility * Fix test runner breaking The test runner script tried to pass the Jest config as stringified JSON, but that was breaking for me somehow. Sidestepped the problem by writing the settings to disk instead and pointing Jest to that file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1137 , by @theKashey.
Perf benchmarks indicate no noticeable difference in performance.
Tagging @timdorr , @shahzaibkhalid , and @glenjamin who were participating in the other thread.