Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 does not support Array.prototype.includes #313

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

nowells
Copy link
Contributor

@nowells nowells commented Jul 26, 2018

#307 broke IE11 due to it not supporting Array.prototype.includes

https://caniuse.com/#feat=array-includes

@timche
Copy link
Member

timche commented Jul 26, 2018

Great catch, thanks a lot 🙏

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          27       27           
  Lines         132      132           
  Branches       39       39           
=======================================
  Hits          127      127           
  Misses          4        4           
  Partials        1        1
Impacted Files Coverage Δ
src/handleAction.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0beaae...3efc4dd. Read the comment docs.

@nowells
Copy link
Contributor Author

nowells commented Jul 26, 2018

Thanks for being so quick to incorporate fixes!!! 🙏

@timche timche merged commit 1a8e5cc into redux-utilities:master Jul 26, 2018
@timche
Copy link
Member

timche commented Jul 26, 2018

Released in v2.6.1: https://github.com/redux-utilities/redux-actions/releases/tag/v2.6.1

@nowells
Copy link
Contributor Author

nowells commented Jul 26, 2018

Do you want me to try to get free cross browser testing support setup? https://www.browserstack.com/open-source?ref=pricing setup Would be pretty straight forward to setup karma unit tests on browserstack to test on IE11. Give some confidence in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants