feat(rename_accounts): accept regexes for renames #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for regex account renames with capturing groups and backreferences.
One use case is calculating the net inflows into an account, excluding internal flows such as dividends, realized capital gains, and fees. Regexes can be used to move these internal flows into
Assets:
, preventing them from affecting the account balance.Unfortunately, this does affect performance even for non-regex renames. On my ledger with 10,000 transactions, with a rename that affects 165 postings, it increases the runtime from 26 ms to 35 ms. If we want to avoid this regression, we could try to detect non-regex renames and use a fast path for those, or we could add a separate user-facing configuration for regex renames.