rename_accounts: Copy only renamed directives for performance #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning seems difficult to fix without an invasive refactoring.
This may give us more flexibility to modify the object in place if desired.
|
Terrific. Thank you for the clear code and for the performance numbers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 caused the
rename_accountsplugin to copy all postings within all transactions, even if they were not renamed. This harmed performance. On my ledger with 10,000 transactions, with a rename that affects 8 postings, it increased the runtime from 15.2 ms to 133.9 ms.This PR fixes the performance regression by copying postings and entries only if they were renamed. This brings the runtime back down to 16.0 ms.