tests: integration testing for compaction with compression #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
changed the title
|
/cdt tests/rptest/scale_tests/many_clients_test.py tests/rptest/scale_tests/many_partitions_test.py |
jcsp
force-pushed
the
tests-compaction-compression
branch
from
4dd0bed
to
0b5a4ff
Compare
|
/cdt tests/rptest/scale_tests |
mmaslankaprv
previously approved these changes
Apr 14, 2023
|
The new compacted variant of manyclientstest failed, needs investigation |
jcsp
force-pushed
the
tests-compaction-compression
branch
from
0b5a4ff
to
c7d2334
Compare
|
/cdt tests/rptest/scale_tests/many_clients_test.py |
jcsp
force-pushed
the
tests-compaction-compression
branch
from
c7d2334
to
167d215
Compare
|
/cdt tests/rptest/scale_tests/many_clients_test.py |
This was referenced Apr 20, 2023
jcsp
force-pushed
the
tests-compaction-compression
branch
from
167d215
to
ff73f40
Compare
|
Clustered ducktape run of manyclientstest was OK -- rebased since #10235 merged, this should be good to go now. |
jcsp
requested review from
dotnwat,
mmaslankaprv,
andrwng and
VladLazar
and removed request for
gousteris
VladLazar
previously approved these changes
May 2, 2023
This test was designed to run with minimal memory, and it necessarily needs more memory when handling huge 32MiB batches that must be compressed+decompressed.
This adds support for --messages-per-second
Running all clients at max speed against a rate limited cluster results in a very unpredictable runtime, because some clients end up backing off for a very long time. Fixes redpanda-data#10092
- Use rate limiting in the client, so that it is not vulnerable to very long delays from rate limiting, causing rare timeouts due to statistical unfairness of which clients get limited. - Add a 'realistic' compaction case to accompany the pathological case. Realistic is incompressible data, so we're just paying the CPU tax, pathological is zeros, where we hit the memory inflation risk. - Make the test adaptively choose messages counts for a target runtime. - Configure a node rate limit that is aligned with the IOPs throughput of i3en.xlarge nodes when we are sending lots of tiny messages. - Set a heuristic "effective message size" for the pathological compaction/compression case, which reflects the equivalent uncompressed message size for throughput calculation purposes. Fixes redpanda-data#10092
jcsp
force-pushed
the
tests-compaction-compression
branch
from
ff73f40
to
2afdfc2
Compare
|
/cdt tests/rptest/scale_tests/many_clients_test.py |
1 similar comment
|
/cdt tests/rptest/scale_tests/many_clients_test.py |
VladLazar
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9521 exposed a lack of coverage in this area.
The tests are separate to the fixes, because the fixes will be backportable and the tests won't.
In this PR:
mixedmode that exercises several different codecs at the same time, and an optional highly-compressible payload that can enable huge records (100MB+) to sneak into the cluster under test by compressing below the batch size limit.ManyClientsTestthat uses compaction: this works well as a reproducer for issues like LZ4 decompression allocates contiguous memory for output buffer #9521, where many concurrent produce requests can try and get memory for their uncompressed batches at the same time.Fixes: #10092
Backports Required
Release Notes