Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: raise on HTTP errors in installer #8879

Merged
merged 1 commit into from
Feb 14, 2023
Merged

tests: raise on HTTP errors in installer #8879

merged 1 commit into from
Feb 14, 2023

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Feb 14, 2023

This happens if you get e.g. a 403 for rate limiting.

Previously we'd get a nondescript exception trying to read an attribute off the response.

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

None

Release Notes

  • none

@jcsp
tests: raise on HTTP errors in installer
9b6daff 
This happens if you get e.g. a 403 for rate limiting.

Previously we'd get a nondescript exception trying
to read an attribute off the response.
@jcsp jcsp requested a review from andrwng February 14, 2023 18:54
@jcsp
Copy link
Contributor Author

jcsp commented Feb 14, 2023

Failure is:

@jcsp jcsp merged commit 8c4afc7 into redpanda-data:dev Feb 14, 2023
@jcsp jcsp deleted the tests-installer-http-error branch February 14, 2023 23:35
@jcsp jcsp mentioned this pull request Feb 16, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcsp @andrwng