e2e_topic_recovery_test: have s3 check the delta offset #8856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test currently waits for a target Redpanda offset to be uploaded, and then checks that the correct number of Kafka offsets are consumable. This isn't quite right, since we also need to take into account config batches in our Redpanda offsets. This updates the test to take into account the 'delta_offset_end' field of the last offset, which should give us an accurate view of the number of Kafka data batches in the topic.
jcsp
approved these changes
Feb 14, 2023
|
Nice. This was for a test failure, right? Can you link the issue with a |
|
/backport v22.3.x |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
Failed to run cherry-pick command. I executed the below command: |
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test currently waits for a target Redpanda offset to be uploaded, and then checks that the correct number of Kafka offsets are consumable. This isn't quite right, since we also need to take into account config batches in our Redpanda offsets.
This updates the test to take into account the 'delta_offset_end' field of the last offset, which should give us an accurate view of the number of Kafka data batches in the topic.
Fixes #8876
Backports Required
UX Changes
Release Notes