kafka: move processing loop into connect context #8135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The processing loop for a kafka connection was implemented at the server level despite being part of the processing pipeline for a connection. This commit moves that loop into the connection context itself. Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
graphcareful
previously approved these changes
Jan 10, 2023
| @@ -213,10 +213,10 @@ ss::future<> server::apply(ss::lw_shared_ptr<net::connection> conn) { | |||
| mtls_state, | |||
| config::shard_local_cfg().kafka_request_max_bytes.bind()); | |||
|
|
|||
| co_return co_await ss::do_until( | |||
| [ctx] { return ctx->is_finished_parsing(); }, | |||
There was a problem hiding this comment.
nit: is_finished_parsing() can be private now
Signed-off-by: Noah Watkins <[email protected]>
graphcareful
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processing loop for a kafka connection was implemented at the server
level despite being part of the processing pipeline for a connection.
This commit moves that loop into the connection context itself.
Backports Required
UX Changes
Release Notes