[v22.3.x] cloud_storage: fix kafka::offset lookup in partition_manifest #8126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for debugging issues with segment selection on the fetch path. (cherry picked from commit 0161370)
When serving a fetch request by a kafka::offset, we previously used the `partition_manifest` to perform a segment lookup by `kafka::offset_cast(ko)` first in order to traverse the segments forward to find the actual segment that contained `ko`. This doesn't work when the manifest has been truncated, e.g. if the casted offset falls before the start of the manifest, we would previously return that no segment exists for the fetch. This could result in segments erronesouly not being returned, and fetches erroneously being met with no data when some existed. This commit fixes the behavior to no longer use the casted segment lookup and adds some test coverage for kafka::offset lookups. Fixes redpanda-data#7708 (cherry picked from commit 10f87c1)
Lazin
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #8110
Fixes #8125,