Fix #8083: Timeout in ControllerUpgradeTest.test_updating_cluster_when_executing_operations #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New CI failure in ControllerUpgradeTest.test_updating_cluster_when_executing_operations. The problem was already present there but it was hidden by the faulty rpk wrapper which were treating failure as a success (fixed in this PR). We should not consider it as a blocker since it was already there. |
rystsov
force-pushed
the
issue-8083
branch
2 times, most recently
from
85f4114
to
ce4c8f3
Compare
parsing the output to fail on anything but success to avoid slipping failures as success
|
LGTM, needs fixing for python lint errors. I edited the Fixes line to make it Related, because this PR is not resolving the failure (it's failing the same way, just with a cleaner error instead of a timeout) |
jcsp
changed the title
6 tasks
AdminOperationsFuzzer retries operations when they fail assuming they are idempotent but some operations used to use randomness leading to strange effects, fixing them to use randomness only on initialization
I had segregated the errors:
This PR fixes #8083 Edited it back |
rystsov
changed the title
jcsp
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix timeout in ControllerUpgradeTest.test_updating_cluster_when_executing_operations caused by treating failed
rpk.alter_topic_configas if it were successful.Fixes #8083
Backports Required
UX Changes
Release Notes