dashboard: remove unused dashboard code #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an undocumented feature, believed to be unused, that we haven't touched in over a year.
emaxerrno
reviewed
May 4, 2022
| @@ -43,7 +43,7 @@ struct node_config final : public config_store { | |||
|
|
|||
| // HTTP server content dirs | |||
| property<ss::sstring> admin_api_doc_dir; | |||
| property<std::optional<ss::sstring>> dashboard_dir; | |||
| deprecated_property dashboard_dir; | |||
|
lgtm from product. kowl supersedes this. |
jcsp
requested review from
dotnwat,
mmaslankaprv,
yougotashovel,
a team and
dswang
as code owners
yougotashovel
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Corresponding vtools change is https://github.com/redpanda-data/vtools/pull/631
Release notes
Improvements
dashboard_dirnode configuration property is no longer removed.