Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-7725 debug bundle metrics #23587

Merged

Conversation

michael-redpanda
Copy link
Contributor

Added metrics to debug bundle service:

  • last_successful_bundle_timestamp_seconds - timestamp in seconds since epoch of last successful debug bundle generation
  • last_failed_bundle_timestamp_seconds - timestamp in seconds since epoch of last failed debug bundle generation
  • successful_generation_count - count of successful generations
  • failed_generation_count - count of failed generations

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • None

@michael-redpanda
Copy link
Contributor Author

Force push 9dd38fb:

  • Reloading metrics from metadata
  • Added tests for post restart

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 2, 2024

@michael-redpanda
Copy link
Contributor Author

Force push 247ab84:

  • Moved cleanup of _probe pointer to after releasing the gate

Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one required change and some nits

src/v/debug_bundle/types.h Show resolved Hide resolved
src/v/debug_bundle/BUILD Show resolved Hide resolved
src/v/debug_bundle/probe.cc Outdated Show resolved Hide resolved
src/v/debug_bundle/probe.h Outdated Show resolved Hide resolved
src/v/debug_bundle/debug_bundle_service.cc Outdated Show resolved Hide resolved
src/v/debug_bundle/metadata.h Outdated Show resolved Hide resolved
@michael-redpanda
Copy link
Contributor Author

Force push 3d41dfc:

  • Updates for PR comments

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/55652#01924dd6-1b75-4169-858d-ecf49efcaf86:

"rptest.tests.rpk_generate_test.RpkGenerateTest.test_generate_grafana"

@michael-redpanda
Copy link
Contributor Author

Only failure: "rptest.tests.rpk_generate_test.RpkGenerateTest.test_generate_grafana"

Looks like a PR is up (#23607) to fix this

@michael-redpanda michael-redpanda merged commit 1442931 into redpanda-data:dev Oct 3, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants