[v24.2.x] CORE-7738: pp/httpd: Remove extra decode on path param get #23547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seastar::http::request::get_path_param performs URL decoding automatically. When this path was updated to use the new method, the pre-existing URL decode behavior was left in place. This is usually not noticeable because decoding an un-encoded string is a no-op. However, that's not the case if the decoded string itself contains URL escape sequences. For example, given the path parameter "foo%252Fbar": - decoded once: "foo%2Fbar" - decoded twice: "foo/bar" So this commit removes the "extra" decode step from the PP httpd module and adds a ducktape test to confirm that URL escape sequences are preserved in a client-provided subject name, the specific case that led to this fix. Unfortunately, get_path_param destroys some information such that distinguishing between an absent parameter and an ill-formed parameter is no longer possible. So this commit includes a bit of extra logic for the nominally unlikely case where get_path_param returns an empty string. CORE-7738 Signed-off-by: Oren Leiman <[email protected]> (cherry picked from commit bcab3ff)
|
CI Failures:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23529