Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] CORE-7338 license: add metric #23467

Conversation

pgellert
Copy link
Contributor

@pgellert pgellert commented Sep 24, 2024

Backport of PR #23367

Fixes #23454

Conflicts were on the storage test bazel BUILD file and on some of the headers in feature_table.cc and feature_table_test.cc.

Expose the expiration as a time_point.

(cherry picked from commit 78de1c7)
These two fixture tests create multiple `feature_table`s at the same
time. This commit disables emitting metrics on these tests to prevent
double metric registration errors in the follow up commit of this PR.

(cherry picked from commit 1c8f66b)
@pgellert pgellert added this to the v24.1.x-next milestone Sep 24, 2024
@pgellert pgellert added the kind/backport PRs targeting a stable branch label Sep 24, 2024
@pgellert pgellert self-assigned this Sep 24, 2024
@pgellert pgellert marked this pull request as ready for review September 24, 2024 17:19
Adds a metric to allow easier monitoring of when the enterprise license
is going to expiry.

The dependency on the `security` module existed even previously in the
bazel build but it was missing from the cmake build.

(cherry picked from commit edb5f48)
Adds a bazel build for the features module.

The include for base/vlog.h was unused, so it was removed instead of
adding a dependency.

(cherry picked from commit c44d9d8)
Adds an integration test for the license expiry metric.

(cherry picked from commit baece2c)
@pgellert pgellert force-pushed the vbotbuildovich/backport-23367-v24.1.x-501 branch from 677935d to 20d57e4 Compare September 24, 2024 17:21
@pgellert pgellert merged commit a23ba2a into redpanda-data:v24.1.x Sep 25, 2024
19 checks passed
@BenPope BenPope modified the milestones: v24.1.x-next, v24.1.18 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants