[v24.2.x] CORE-7338 license: add metric #23466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the expiration as a time_point. (cherry picked from commit 78de1c7)
These two fixture tests create multiple `feature_table`s at the same time. This commit disables emitting metrics on these tests to prevent double metric registration errors in the follow up commit of this PR. (cherry picked from commit 1c8f66b)
Adds a metric to allow easier monitoring of when the enterprise license is going to expiry. The dependency on the `security` module existed even previously in the bazel build but it was missing from the cmake build. (cherry picked from commit edb5f48)
Adds a bazel build for the features module. The include for base/vlog.h was unused, so it was removed instead of adding a dependency. (cherry picked from commit c44d9d8)
Adds an integration test for the license expiry metric. (cherry picked from commit baece2c)
pgellert
requested review from
a team and
andijcr
and removed request for
a team
pgellert
requested review from
BenPope and
oleiman
and removed request for
andijcr
oleiman
reviewed
Sep 24, 2024
| @@ -0,0 +1,17 @@ | |||
| load("//bazel:test.bzl", "redpanda_cc_btest") | |||
There was a problem hiding this comment.
I'll note that I'm not really clear on the guidance with respect to backporting BUILD files. I heard Noah say in core panda that it's not necessary, but I don't have a good sense of whether we should actively avoid doing it.
I don't think there's any harm in it, but it might be worth asking
There was a problem hiding this comment.
Yeah, that's my understanding as well. I've checked, and there's a thread in Slack saying that we only care about the bazel build on the dev branch (and 25.1 in the future).
BenPope
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23367
Fixes #23455
Conflict was on the storage test bazel BUILD file which was missing the unit test configs on this branch.