archival: skip spillover retention if not collectable #23358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compact-only topics should never apply retention. This wasn't the case for the spillover region in tiered storage. Note, for the STM region, we do correctly no-op when trying to apply retention for compacted topics.
This was referenced Sep 18, 2024
abhijat
approved these changes
Sep 18, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54647#0192041f-309e-471a-b2a5-5c8263d4236d |
nvartolomei
reviewed
Sep 18, 2024
| ASSERT_GE(total_records, 500); | ||
| ASSERT_TRUE(archiver.sync_for_tests().get()); | ||
| archiver.apply_spillover().get(); | ||
| ss::sleep(5s).get(); |
There was a problem hiding this comment.
would be nice to document why this sleep is needed or better wait for the specific condition we are looking for
There was a problem hiding this comment.
Will remove in a follow-up. Want to merge this one ASAP
nvartolomei
reviewed
Sep 18, 2024
| .set_value(std::make_optional<size_t>(5)); | ||
| test_local_cfg.get("cloud_storage_spillover_manifest_size") | ||
| .set_value(std::optional<size_t>{}); | ||
| test_local_cfg.get("log_retention_ms") |
There was a problem hiding this comment.
can we do log_retention_bytes to avoid relying on timers?
There was a problem hiding this comment.
Will do in a follow-up. Want to merge this one ASAP
|
/backport v24.2.x |
|
/backport v24.1.x |
|
/backport v23.3.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
|
Failed to create a backport PR to v24.1.x branch. I tried: |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compact-only topics should never apply retention. This wasn't the case for the spillover region in tiered storage.
Note, for the STM region, we do correctly no-op when trying to apply retention for compacted topics.
Backports Required
Release Notes
Bug Fixes