[v24.1.x] cluster: don't apply invalid property change in topic_table (Manual backport)
#23226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check that the updated topic properties post `topic_table::apply(update_topic_properties_cmd)` is valid with the `schema_id_validation_validator`. However, this early `co_return` with an error code does not actually prevent the invalid configuration from being persisted in the `topic_table`. Rework the logic in `topic_table::apply()` to prevent persisting of an invalid configuration. (cherry picked from commit 3a36f7a)
To ensure updates made from invalid `update_topic_properties_cmd` are not persisted in `topic_properties`. (cherry picked from commit 6da3157)
pgellert
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #23191. Merge conflict due to other unrelated migration additions in
topic_table.cc.Closes #23221.
Backports Required
Release Notes
Bug Fixes
topic_propertiesconfiguration in thetopic_table.