Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport pr #23167 to v24.2.x #23209

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Backport pr #23167 to v24.2.x #23209

merged 3 commits into from
Sep 12, 2024

Conversation

bashtanov
Copy link
Contributor

@bashtanov bashtanov commented Sep 5, 2024

backport #23167 (High level topic mount/unmount APIs)

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Features

  • New REST API for mounting/unmounting topics

@bashtanov
Copy link
Contributor Author

/dt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like the change from the cherry-picked commit is not there, instead there is a bunch of unrelated changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's the formatter. I'll exclude this file from the PR, as Bazel is half-baked in v24.2.x so the actual change cannot be applied. Thanks

Moved the data migration related utility functions to separate file to
make them reusable for topic load/unload handlers.

Signed-off-by: Michał Maślanka <[email protected]>
(cherry picked from commit b346d8d)
Added definitions for topic mount/unmount REST APIs. The definitions are
placed in `migrations.json` file which is counter intuitive but it
allows reusing the data migration related definitions.

Signed-off-by: Michał Maślanka <[email protected]>
(cherry picked from commit 8d4b002)
Added handlers that provide a wrapper around raw data migration APIs.
The operations support mounting and unmounting multiple topics at a
time. The handler creates a corresponding data migration objects and
returns underlying migration id.

Signed-off-by: Michał Maślanka <[email protected]>
(cherry picked from commit 6d2bb36)
@bashtanov bashtanov requested a review from ztlpn September 9, 2024 11:48
@bashtanov
Copy link
Contributor Author

@lf-rep lf-rep merged commit 63d9c22 into v24.2.x Sep 12, 2024
14 of 18 checks passed
@lf-rep lf-rep deleted the backport-pr-23167-v24.2.x-460 branch September 12, 2024 08:33
@BenPope BenPope added this to the v24.2.5 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants