Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rptest: tolerate leadership changes in chunk read tests #21344

Conversation

nvartolomei
Copy link
Contributor

DeleteRandomChunks worker must refresh knowledge about current leader otherwise it might act on an unrelated node, report that it was unable to delete any chunks, and fail the test.

Spotted in a backport build https://buildkite.com/redpanda/redpanda/builds/51354#0190a1a8-8687-4687-b3c6-e0ac3c9f55cc

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

DeleteRandomChunks worker must refresh knowledge about current leader
otherwise it might act on an unrelated node, report that it was unable
to delete any chunks, and fail the test.
@nvartolomei nvartolomei requested a review from abhijat July 11, 2024 13:52
@nvartolomei
Copy link
Contributor Author

This test has another problem when leadership changes in the metric check btw. Ignoring it for now.

m = MetricCheck(self.logger,
                        self.redpanda,
                        self.redpanda.partitions(self.topic)[0].leader,
                        [metric],
                        labels={
                            'namespace': 'kafka',
                            'topic': self.topic,
                            'partition': '0',
                        })

@vbotbuildovich
Copy link
Collaborator

@nvartolomei
Copy link
Contributor Author

All failures are unrelated and inside CertificateRevocationTest which have nothing to do with this PR which changes only a specific test.

@dotnwat please help merge this 🙇

@piyushredpanda piyushredpanda merged commit 5dceaef into redpanda-data:dev Jul 13, 2024
14 of 17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants