-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha/labeler: fix format of yml file for v5 #19625
Conversation
The v5 of labeler has breaking change that needs update to the configuration file: https://github.com/actions/labeler/tree/v5.0.0?tab=readme-ov-file#breaking-changes-in-v5 This fixes it and retains existing behavior. Just syntax differences.
c480fff
to
d2e7e86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@redpanda-data/core-admin this PR needs forcing merge because the PR job cannot validate the labeler.yml syntax update. known issue with labeler config changes in issue: actions/labeler#712 (comment) |
i'm force-merging because i have approval and (temp) permissions |
/backport v24.1.x |
/backport v23.3.x |
/backport v23.2.x |
follow-on to PR #18857
fixes error in
Pull Request Labeler / triage (pull_request_target)
check:The v5 of labeler has breaking change that needs update to the configuration file:
https://github.com/actions/labeler/tree/v5.0.0?tab=readme-ov-file#breaking-changes-in-v5
This fixes it and retains existing behavior. Just syntax differences.
Unfortunately, the gha job
triage
will fail using label v5 until this PR is merged todev
branch because of known issue actions/labeler#712 (comment), so needs a force merge.I recommend merging this PR to keep the fixes for nodejs that were brought in with labeler v5. But if this PR is merged, then PR #19626 should not be merged.
jira: https://redpandadata.atlassian.net/browse/PESDLC-1510
Backports Required
Release Notes