-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-2503] Fix for CI failure: ControlCharacterPermittedAfterUpgrade.test_upgrade_from_pre_v23_2
#18695
[CORE-2503] Fix for CI failure: ControlCharacterPermittedAfterUpgrade.test_upgrade_from_pre_v23_2
#18695
Conversation
- This upgrade test failed because the iterative upgrade through rp version loop wasn't waiting until the cluster active version had changed, between each install and upgrade of a new version. - It therefore isn't enough to wait until all binaries report the desired version, but for the cluster logical version to also have been bumped. - The solution is to use the already existing method `upgrade_through_versions` which properly waits between installs of the next redpanda version before starting another install and restart.
may be worthwhile to do a dt-repeat on that test just to make sure... it wasn't always failing |
/ci-repeat 3 |
/backport v24.1.x |
/backport v23.3.x |
/backport v23.2.x |
Failed to create a backport PR to v23.3.x branch. I tried:
|
Failed to create a backport PR to v23.2.x branch. I tried:
|
This upgrade test failed because the iterative upgrade through rp version loop wasn't waiting until the cluster active version had changed, between each install and upgrade of a new version.
It therefore isn't enough to wait until all binaries report the desired version, but for the cluster logical version to also have been bumped.
The solution is to use the already existing method
upgrade_through_versions
which properly waits between installs of the next redpanda version before starting another install and restart.Fixes: https://redpandadata.atlassian.net/browse/CORE-2503
Fixes: https://redpandadata.atlassian.net/browse/CORE-2631
Backports Required
Release Notes