Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-2503] Fix for CI failure: ControlCharacterPermittedAfterUpgrade.test_upgrade_from_pre_v23_2 #18695

Merged

Conversation

graphcareful
Copy link
Contributor

@graphcareful graphcareful commented May 29, 2024

  • This upgrade test failed because the iterative upgrade through rp version loop wasn't waiting until the cluster active version had changed, between each install and upgrade of a new version.

  • It therefore isn't enough to wait until all binaries report the desired version, but for the cluster logical version to also have been bumped.

  • The solution is to use the already existing method upgrade_through_versions which properly waits between installs of the next redpanda version before starting another install and restart.

Fixes: https://redpandadata.atlassian.net/browse/CORE-2503
Fixes: https://redpandadata.atlassian.net/browse/CORE-2631

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

- This upgrade test failed because the iterative upgrade through rp
version loop wasn't waiting until the cluster active version had
changed, between each install and upgrade of a new version.

- It therefore isn't enough to wait until all binaries report the
desired version, but for the cluster logical version to also have been
bumped.

- The solution is to use the already existing method
`upgrade_through_versions` which properly waits between installs of the
next redpanda version before starting another install and restart.
@michael-redpanda
Copy link
Contributor

may be worthwhile to do a dt-repeat on that test just to make sure... it wasn't always failing

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
debug
skip-units
dt-repeat=50
tests/rptest/tests/control_character_flag_test.py::ControlCharacterPermittedAfterUpgrade.test_upgrade_from_pre_v23_2

@graphcareful graphcareful merged commit 241b990 into redpanda-data:dev May 30, 2024
24 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-18695-v23.3.x-900 remotes/upstream/v23.3.x
git cherry-pick -x 44ebe1037ea141d79d52bd58f9da21e12d2f8f3e

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-18695-v23.2.x-740 remotes/upstream/v23.2.x
git cherry-pick -x 44ebe1037ea141d79d52bd58f9da21e12d2f8f3e

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants