storage: change map type for _db in kvstore
#18499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
previously approved these changes
May 15, 2024
| #include "bytes/iobuf.h" | ||
| #include "container/chunked_hash_map.h" | ||
| #include "metrics/metrics.h" | ||
| #include "storage/fwd.h" | ||
| #include "storage/ntp_config.h" |
There was a problem hiding this comment.
good to remove the btree include further down?
|
also backport to 24.1 at least? |
In an effort to move to fragmented data structures, the `absl::btree_map` type used in the `kvstore` is now replaced by a `chunked_hash_map`. We do not rely on the ordering or any sort of pointer/reference/iterator stability provided by `absl::btree_map` in our current uses of `_db`, so this is a painless swap.
WillemKauf
force-pushed
the
fragmented_kv_store_map
branch
from
85fe2a3
to
88a1614
Compare
StephanDollberg
approved these changes
May 15, 2024
|
/backport v24.1.x |
This was referenced May 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to move to fragmented data structures, the
absl::btree_maptype used in thekvstoreis now replaced by achunked_hash_map.We do not rely on the ordering or any sort of pointer/reference/iterator stability provided by
absl::btree_mapin our current uses of_db, so this is a painless swap.Fixes #15906
Fixes #10744
Backports Required
Release Notes