Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] admin: stream more json results #16747

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

michael-redpanda
Copy link
Contributor

@michael-redpanda michael-redpanda commented Feb 27, 2024

Backport of PR #16551

Fixes: #16716

michael-redpanda and others added 2 commits February 27, 2024 08:50
The current approach can lead to an oversized allocation. This is not a
full solution as get_leaders needs to not be prone to reactor stalls and
oversized allocs.

Signed-off-by: Tyler Rockwood <[email protected]>
(cherry picked from commit 34d9ec9)
Signed-off-by: Tyler Rockwood <[email protected]>
(cherry picked from commit 2818c02)
@michael-redpanda michael-redpanda added this to the v23.2.x-next milestone Feb 27, 2024
@michael-redpanda michael-redpanda added the kind/backport PRs targeting a stable branch label Feb 27, 2024
@michael-redpanda michael-redpanda self-assigned this Feb 27, 2024
@michael-redpanda michael-redpanda marked this pull request as ready for review February 27, 2024 13:59
@michael-redpanda
Copy link
Contributor Author

/dt

BenPope
BenPope previously approved these changes Feb 27, 2024
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/v/redpanda/admin_server.cc Show resolved Hide resolved
@michael-redpanda michael-redpanda dismissed BenPope’s stale review February 27, 2024 16:50

Missing a line in the backport

Signed-off-by: Tyler Rockwood <[email protected]>
(cherry picked from commit 3b0ef74)
@michael-redpanda michael-redpanda force-pushed the vbotbuildovich/backport-16551-v23.2.x-297 branch from c94fdf9 to 2dcc64d Compare February 27, 2024 16:54
@michael-redpanda
Copy link
Contributor Author

Force push 2dcc64d:

  • Added missing maybe_yield

@michael-redpanda
Copy link
Contributor Author

/dt

@michael-redpanda
Copy link
Contributor Author

@michael-redpanda michael-redpanda merged commit 0785122 into v23.2.x Feb 28, 2024
26 of 29 checks passed
@michael-redpanda michael-redpanda deleted the vbotbuildovich/backport-16551-v23.2.x-297 branch February 28, 2024 18:56
@BenPope BenPope modified the milestones: v23.2.x-next, v23.2.27 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v23.2.x] admin: stream more json results
3 participants