[v23.2.x] c/archival_stm: do not reset _last_replicate on timeout #15816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cdt |
|
/cdt |
|
/cdt |
nvartolomei
force-pushed
the
nv/backport-15677-v23.2.x-768
branch
from
01d5163
to
2a0b14a
Compare
|
/cdt |
|
/dt |
|
Failures:
|
Lazin
approved these changes
Dec 22, 2023
|
@dotnwat last one before Christmas. 🙏 |
For same term syncing we store the replicate commands future so that it can be awaited in the next sync call. However, the `std::exchange(_last_replicate, std::nullopt)` before the wait is problematic as it "forgets" the last replicate. If sync times out and we retry it then it behaves as if the last replicate command succeeded. This is not necessarily true as the newly added test assertion shows. Use a shared future for _last_replicate so that it can be awaited multiple times and reset it only after it is resolved. This guarantees that sync will only return after last replicate command actually resolved. `ignore_ready_future` call is removed as the shared future does not issue a warning if it wasn't consumed (basically a revert of e221a0a). (cherry picked from commit 299e12d)
Some operations try to sync with relatively low timeouts. Under stress, they are expected to time out occasionally. This is a warning at most. Downgrade the log level to avoid spooking users and ducktape tests.
This is already present in dev. Tests that rely on blocking s3 traffic via iptables rely on this.
nvartolomei
force-pushed
the
nv/backport-15677-v23.2.x-768
branch
from
2a0b14a
to
2405b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
Fixes #15783
Backports Required
Release Notes