Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled partitions implementation #15141

Merged
merged 12 commits into from
Nov 29, 2023
Merged

Disabled partitions implementation #15141

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
76aaf2c
c/partition_balancer: skip disabled partitions
ztlpn Nov 5, 2023
d7bf116
c/leader_balancer: skip balancing disabled partitions
ztlpn Nov 5, 2023
f8e3ab6
cluster: forbid reallocation ops for disabled topics/partitions
ztlpn Nov 5, 2023
a5cb9d9
c/metadata_cache: add getters for disabled topics/partitions
ztlpn Nov 6, 2023
5f018c6
cluster/tx: return tx_errc::partition_disabled where appropriate
ztlpn Nov 6, 2023
8c40e8e
kafka: return appropriate ec's for requests touching disabled partitions
ztlpn Nov 6, 2023
e612596
cluster: generate disabled_flag_updated topic_table delta
ztlpn Nov 20, 2023
343115c
cluster: handle disabled_flag_updated delta type in controller_backend
ztlpn Nov 20, 2023
b441e63
tests: test producing/consuming to disabled partitions
ztlpn Nov 23, 2023
b1449fe
cluster: forbid disabling internal topics/partitions
ztlpn Nov 27, 2023
d342e60
cluster: forbid creating transforms to/from fully disabled topics
ztlpn Nov 29, 2023
4937cf6
transform: choose non-disabled output partition
ztlpn Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/v/cluster/plugin_frontend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,14 @@ errc plugin_frontend::validator::validate_mutation(const transform_cmd& cmd) {
loggable_string(cmd.value.input_topic.tp()));
return errc::transform_invalid_create;
}
if (_topics->is_fully_disabled(cmd.value.input_topic)) {
vlog(
clusterlog.info,
"attempted to deploy transform {} to a disabled topic {}",
cmd.value.name,
loggable_string(cmd.value.input_topic.tp()));
return errc::transform_invalid_create;
}
if (cmd.value.output_topics.empty()) {
vlog(
clusterlog.info,
Expand Down Expand Up @@ -534,6 +542,15 @@ errc plugin_frontend::validator::validate_mutation(const transform_cmd& cmd) {
out_name.tp);
return errc::transform_invalid_create;
}
if (_topics->is_fully_disabled(out_name)) {
ztlpn marked this conversation as resolved.
Show resolved Hide resolved
vlog(
clusterlog.info,
"attempted to deploy transform {} to write to a disabled "
"topic {}",
cmd.value.name,
loggable_string(out_name.tp()));
return errc::transform_invalid_create;
}
if (would_cause_cycle(cmd.value.input_topic, out_name)) {
vlog(
clusterlog.info,
Expand Down