cloud_storage: Log client address in batch parser #14957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andijcr
previously approved these changes
Nov 14, 2023
| vlog(_ctxlog.debug, "remote_segment_batch_reader::stop"); | ||
| vlog( | ||
| _ctxlog.debug, | ||
| "remote_segment_batch_reader::stop: {}", |
There was a problem hiding this comment.
minor nit, to have the same structure of the other logs
Suggested change
| "remote_segment_batch_reader::stop: {}", | |
| "[{}] remote_segment_batch_reader::stop", |
There was a problem hiding this comment.
good point, fixed both
| vlog(_ctxlog.debug, "remote_segment_batch_reader::stop - parser-close"); | ||
| vlog( | ||
| _ctxlog.debug, | ||
| "remote_segment_batch_reader::stop - parser-close: {}", |
There was a problem hiding this comment.
nit, same as above
Suggested change
| "remote_segment_batch_reader::stop - parser-close: {}", | |
| "[{}] remote_segment_batch_reader::stop - parser-close", |
abhijat
force-pushed
the
log-client-address-in-remote-batch-parser
branch
from
9b097b0
to
f81ee32
Compare
The client address is added to the remote segment batch parser logs. The address cannot be set as a member because a remote segment reader may be cached and have its configuration reset. The client address is always read from the configuration to make sure we get the latest address. (cherry picked from commit 0996d4f)
abhijat
force-pushed
the
log-client-address-in-remote-batch-parser
branch
from
f81ee32
to
e4de1ce
Compare
andijcr
approved these changes
Nov 14, 2023
|
/backport v23.2.x |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/41078#018bcd30-f580-4166-93df-4c82eab37ae5: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/41078#018bcd30-f580-4166-93df-4c82eab37ae5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client address is added to the remote segment batch parser logs. The address cannot be set as a member because a remote segment reader may be cached and have its configuration reset. The client address is always read from the configuration to make sure we get the latest address.
Backports Required
Release Notes