-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf: update Redpanda configuration file #14600
Conversation
The other option is to explicitly only listen on the local loopback, but I'm not sure if that will break anything. |
As I understand it, listening on ANY is generally fine, so I'd favor the minimally scoped change you have here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks @rockwotj :)
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b6d-b492-43f0-b67a-8aeb4d0f71b8: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b6d-b495-4baa-a8b4-caa0b3098e83: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b74-5f6e-4f7c-943f-23f6c48bddc8: "rptest.tests.cluster_features_test.FeaturesSingleNodeTest.test_get_features" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b6d-b48b-4a22-af5a-beec0a138dd2: "rptest.tests.cluster_features_test.FeaturesSingleNodeTest.test_get_features" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b74-5f75-4e0d-9806-b429d5ac17d1: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b74-5f78-4a40-a807-94e97e5faa80: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b74-5f71-4e53-abf3-617b092469fb: "rptest.tests.cluster_features_test.FeaturesSingleNodeUpgradeTest.test_upgrade" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40240#018b8b6d-b48e-4b66-b2f4-dcff3bd85d18: "rptest.tests.cluster_features_test.FeaturesSingleNodeUpgradeTest.test_upgrade" |
We don't allow advertised addresses of `0.0.0.0` so in our example configuration explicitly set localhost configuration values. This allows Redpanda to boot using this configuration. Signed-off-by: Tyler Rockwood <[email protected]>
Force push: Fix RPK test that reads |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8caa-7c2d-473b-af29-50576408b2bb: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8caa-7c30-4d59-a227-d8a08cf7b349: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8caa-7c28-4002-88dd-6e5d6cb0a2d7: "rptest.tests.cluster_features_test.FeaturesSingleNodeTest.test_get_features" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8caa-7c2b-45f7-b0be-25798905470c: "rptest.tests.cluster_features_test.FeaturesSingleNodeUpgradeTest.test_upgrade" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8cb0-d863-482c-a0cf-72adb8ac2649: "rptest.tests.cluster_features_test.FeaturesSingleNodeTest.test_get_features" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8cb0-d868-4ba0-8a04-6221e3aac42d: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=node_add" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8cb0-d86b-49e8-afae-6425c4fc7159: "rptest.tests.node_pool_migration_test.NodePoolMigrationTest.test_migrating_redpanda_nodes_to_new_pool.balancing_mode=off" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40260#018b8cb0-d866-4cae-9185-6b1024e90425: "rptest.tests.cluster_features_test.FeaturesSingleNodeUpgradeTest.test_upgrade" |
/ci-repeat |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40288#018b8ed5-50d2-4d44-971f-6d6aab772c4b: "rptest.tests.topic_recovery_test.TopicRecoveryTest.test_fast2.cloud_storage_type=CloudStorageType.S3" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40288#018b8ed5-50d6-4088-aa39-872539993194: "rptest.tests.rpk_registry_test.RpkRegistryTest.test_produce_consume_proto" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40288#018b8ef5-943e-4db0-b4ff-bad6e3d8c602: "rptest.tests.memory_stress_test.MemoryStressTest.test_fetch_with_many_partitions.memory_share_for_fetch=0.5" |
new failures detected in https://buildkite.com/redpanda/redpanda/builds/40288#018b8ef5-9442-4063-9263-ed72855e2d57: "rptest.tests.memory_stress_test.MemoryStressTest.test_fetch_with_many_partitions.memory_share_for_fetch=0.7" |
These are part of the default configuration we ship (see /redpanda/conf/redpanda.yaml). Internally, Redpanda defaults to select the listener address to be the advertised address if the advertised address is not set. So, this change will at least prevent mistakingly selecting the listener default address (0.0.0.0) as the advertised address, resulting in a failure See also redpanda-data#14600 and redpanda-data#14179
We don't allow advertised addresses of
0.0.0.0
so in our exampleconfiguration explicitly set localhost configuration values.
This allows Redpanda to boot using this configuration.
Backports Required
Release Notes