Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.1.x] schema_registry: Add support for DELETE /config/{subject} #14383

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #13557
Fixes: #14381,

Adds `seq_writer::delete_config`, which deletes the stored compatibility
level for a given subject by producing an empty-valued config write.

Also adds `sharded_store::get_subject_config_written_at` which returns
the sequence number history of a subject's config. This differs from
`get_subject_written_at` in that the sequence markers returned cannot
be used to perm delete the subject itself, only the config. Therefore,
there is no need to soft-delete a subject before fetching this info.

(cherry picked from commit ac100ad)
Adds a handler for the delete endpoint.

To match the behavior of the reference implementation, this endpoint:

- Returns the compatibility level of the subject before deletion
- OR subject_not_found if no compatibility level was previously set

(cherry picked from commit 03e2a34)
@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Oct 23, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Oct 23, 2023
@oleiman oleiman self-assigned this Oct 23, 2023
@oleiman oleiman marked this pull request as ready for review October 24, 2023 03:39
@oleiman oleiman merged commit 093c37a into redpanda-data:v23.1.x Oct 25, 2023
22 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.1.x-next, v23.1.20 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants