[v23.1.x] cluster/topics_frontend: Move some topic preprocessing into create_topics #13852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adds `shadow_indexing` and `cleanup_policy_bitflags` default fallback to `create_topics`. Also plumbs the `metadata_cache` down into `topics_frontend` for this purpose, and in case we need to add more property fallbacks in the future. This commit also relaxes an assertion in a fixture test [1] to account for some additional requests during topic recovery when the test topic has cloud storage switched on. [1] `cloud_storage_rpfixture::topic_recovery_service_test.recovery_with_existing_topic` (cherry picked from commit c417dba)
oleiman
force-pushed
the
vbotbuildovich/backport-13657-v23.1.x-319
branch
from
cc937a6
to
d9a38bc
Compare
|
I think this backport is ill-formed... @andijcr can you confirm? |
seems like the error is |
Sounds good. Wasn't sure how invasive a backport cherry-pick should be. Better to have the fix than not I suppose. |
(cherry picked from commit 7106d1d)
oleiman
force-pushed
the
vbotbuildovich/backport-13657-v23.1.x-319
branch
from
d9a38bc
to
e13c0af
Compare
|
/ci-repeat 1 |
andijcr
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #13657
Fixes #13846