Backport per-handler metrics to v23.1 #13344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
force-pushed
the
stephan/handler-backport-v231
branch
from
96f0b57
to
3ddc163
Compare
StephanDollberg
changed the title
(cherry picked from commit 31b985c)
(cherry picked from commit 56659cb)
(cherry picked from commit afdcdc2)
(cherry picked from commit d78ed20)
…ontext (cherry picked from commit 9e42f80)
Since `request_tracker` will count the completion of the request when it is destroyed this removed line will double count failed completed requests. (cherry picked from commit 1c222ca)
(cherry picked from commit 1cabd8a)
(cherry picked from commit ca7e46f)
This histogram type avoids using `hdr_hist` to generate seastar histograms in metrics. It instead implements a simple powers of two histogram that reduces memory utilization from kilobytes to `number_of_buckets` * sizeof(uint64_t). (cherry picked from commit b1ff1b7)
(cherry picked from commit b774f7f)
(cherry picked from commit 6d314a1)
(cherry picked from commit 69d98d9)
(cherry picked from commit 961178b)
…om log_hist_internal to a public seastar hist Co-authored-by: Ben Pope <[email protected]> (cherry picked from commit 6b578bd)
(cherry picked from commit caa4e92)
This reduces the memory required to store a histogram from kilobytes to 208 bytes. It also speeds up recording to the histogram by 2x. (cherry picked from commit c2959f5)
StephanDollberg
force-pushed
the
stephan/handler-backport-v231
branch
from
3ddc163
to
0329bae
Compare
ballard26
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #10623
Backport of PR #12036
Backport of PR #12295
Backport of PR #12460
Backports all PRs/commits related to per handler metrics.
Backports Required