Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user-specified ServiceAccount name for Console deployment #13120

Merged
merged 1 commit into from
Sep 9, 2023
Merged

allow user-specified ServiceAccount name for Console deployment #13120

merged 1 commit into from
Sep 9, 2023

Conversation

joejulian
Copy link
Contributor

Fixes #12864

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

Features

  • add support to the Console API (deprecated) for a user-specified ServiceAccount

@joejulian joejulian requested a review from a team as a code owner August 30, 2023 17:22
@joejulian joejulian self-assigned this Aug 30, 2023
RafalKorepta
RafalKorepta previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joejulian joejulian force-pushed the add_user_sa_console branch 2 times, most recently from 5d00c75 to 43a0a5f Compare August 30, 2023 18:30
alejandroEsc
alejandroEsc previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafalKorepta
Copy link
Contributor 

pkg/console/deployment_internal_test.go:11:2: dupImport: package is imported 2 times under different aliases on lines 11 and 14 (gocritic)
--
  | metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  | ^
  | pkg/console/deployment_internal_test.go:14:2: dupImport: package is imported 2 times under different aliases on lines 11 and 14 (gocritic)
  | v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  | ^

https://buildkite.com/redpanda/redpanda/builds/36033#018a47c7-6d23-4faa-a5e4-0c9fdf7ad24f/315-411

@alejandroEsc
Copy link
Contributor

good catch, did you run this locally? Seems like something that should have failed in linter.

@RafalKorepta
Copy link
Contributor

It was CI that catches this

RafalKorepta
RafalKorepta approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafalKorepta RafalKorepta merged commit ab1edfe into redpanda-data:dev Sep 9, 2023
25 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich vbotbuildovich mentioned this pull request Sep 9, 2023
Merged
@RafalKorepta
Copy link
Contributor

Bummer. I didn't noticed that make generate and make manifests execution are missing in this PR. I will open PR to addressed that.

RafalKorepta added a commit to RafalKorepta/redpanda that referenced this pull request Sep 10, 2023
@RafalKorepta
k8s: Genreate deepcopy and console custom resource definition
64593e9 
Pervious PR redpanda-data#13120 did not run
custom resource definition generation and deep copy. This commit re-generate
using `make generate manifests` Makefile targets.
@RafalKorepta RafalKorepta mentioned this pull request Sep 10, 2023
Merged
7 tasks
vbotbuildovich pushed a commit to vbotbuildovich/redpanda that referenced this pull request Sep 11, 2023
@RafalKorepta @vbotbuildovich
k8s: Genreate deepcopy and console custom resource definition
20e31ee 
Pervious PR redpanda-data#13120 did not run
custom resource definition generation and deep copy. This commit re-generate
using `make generate manifests` Makefile targets.

(cherry picked from commit 64593e9)
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalKorepta RafalKorepta RafalKorepta approved these changes

@alejandroEsc alejandroEsc Awaiting requested review from alejandroEsc

Assignees

@joejulian joejulian

Labels
area/k8s k8s/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joejulian @RafalKorepta @alejandroEsc @vbotbuildovich