[v23.1.x] Optimize send path error handling #12859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create less of a continuation chain by handling all the exceptions in a single coroutine. Signed-off-by: Tyler Rockwood <[email protected]> (cherry picked from commit 9670361)
Remove the double dose of ssx::handle_shutdown_exceptions by inlining the gate handling into a single place. Remove the extra overhead of some lambdas and a couple of extra continuations by handling unexpected errors and closing the gate in a single continuation. Signed-off-by: Tyler Rockwood <[email protected]> (cherry picked from commit 0b3fa8c)
NyaliaLui
reviewed
Aug 16, 2023
|
I think this is a clang bug with inlining a coroutine function? I think I'll just not do this backport then, it's probably not worth the effort and this is really more of a performance optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12472