Redpanda-Operator: code clean up eventrecorder

[alejandroEsc]

Code clean up: Remove the trace errors we have seen in the logs from the operator:

old:

{"level":"info","ts":"2023-08-04T11:31:15.864-0400","msg":"artifact up-to-date with remote revision: '5.0.7'","controller":"helmchart","controllerGroup":"source.toolkit.fluxcd.io","controllerKind":"HelmChart","HelmChart":{"name":"redpanda-redpanda","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda-redpanda","reconcileID":"77807bdb-892a-4a0b-a55b-eb5e7902daff"}
E0804 11:31:15.864375   43955 event.go:340] Unsupported event type: 'Trace'
{"level":"info","ts":"2023-08-04T11:31:16.075-0400","msg":"artifact up-to-date with remote revision: 'sha256:719cb71cdd95b59f3f0112efc05084b965671da70556018089478555f0fb8b70'","controller":"helmrepository","controllerGroup":"source.toolkit.fluxcd.io","controllerKind":"HelmRepository","HelmRepository":{"name":"redpanda-repository","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda-repository","reconcileID":"530fb493-2768-4799-89fb-814a026bfab8"}
E0804 11:31:16.075830   43955 event.go:340] Unsupported event type: 'Trace'

new:

{"level":"info","ts":"2023-08-04T11:23:21.306-0400","msg":"reconcilation finished in 24.414167ms, next run in 30s","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"redpanda","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda","reconcileID":"b899cda5-ad05-454a-999e-b64b571da79a"}
{"level":"info","ts":"2023-08-04T11:23:24.089-0400","msg":"artifact up-to-date with remote revision: 'sha256:719cb71cdd95b59f3f0112efc05084b965671da70556018089478555f0fb8b70'","controller":"helmrepository","controllerGroup":"source.toolkit.fluxcd.io","controllerKind":"HelmRepository","HelmRepository":{"name":"redpanda-repository","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda-repository","reconcileID":"a0957a4d-c042-42b9-aade-fe7277b6a8e8"}
{"level":"debug","ts":"2023-08-04T11:23:24.089-0400","logger":"events","msg":"artifact up-to-date with remote revision: 'sha256:719cb71cdd95b59f3f0112efc05084b965671da70556018089478555f0fb8b70'","type":"Normal","object":{"kind":"HelmRepository","namespace":"redpanda","name":"redpanda-repository","uid":"7ed529f7-a67e-4444-b81c-0e549792a87d","apiVersion":"source.toolkit.fluxcd.io/v1beta2","resourceVersion":"980"},"reason":"ArtifactUpToDate"}
{"level":"info","ts":"2023-08-04T11:23:51.351-0400","msg":"reconcilation finished in 43.926958ms, next run in 30s","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"redpanda","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda","reconcileID":"2ccab815-da2c-484f-9896-f6a430825264"}
{"level":"info","ts":"2023-08-04T11:23:54.501-0400","msg":"artifact up-to-date with remote revision: 'sha256:719cb71cdd95b59f3f0112efc05084b965671da70556018089478555f0fb8b70'","controller":"helmrepository","controllerGroup":"source.toolkit.fluxcd.io","controllerKind":"HelmRepository","HelmRepository":{"name":"redpanda-repository","namespace":"redpanda"},"namespace":"redpanda","name":"redpanda-repository","reconcileID":"9a33099f-cc1d-4680-9d3c-cb599aeac0ad"}

Fixes: #10807

Events exist as expected:

5m35s       Warning   error                        helmrelease/redpanda                                          reconciliation failed: Helm install failed: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "redpanda-default-root-certificate" namespace: "redpanda" from "": no matches for kind "Certificate" in version "cert-manager.io/v1"...
4m5s        Warning   error                        helmrelease/redpanda                                          reconciliation failed: install retries exhausted
3m8s        Normal    NoPods                       poddisruptionbudget/redpanda                                  No matching pods found
3m8s        Normal    SuccessfulCreate             statefulset/redpanda                                          create Claim datadir-redpanda-0 Pod redpanda-0 in StatefulSet redpanda success
3m8s        Normal    SuccessfulCreate             statefulset/redpanda                                          create Pod redpanda-0 in StatefulSet redpanda successful
99s         Normal    info                         helmrelease/redpanda                                          Helm install succeeded
99s         Normal    info                         redpanda/redpanda                                             HelmRelease 'redpanda/redpanda' is ready

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v23.2.x
• v23.1.x
• v22.3.x

Release Notes

• none

[RafalKorepta]

LGTM

[alejandroEsc]

The changes here do not affect v1 operator. So ill try to get the tests to pass but will merge if next round fails again.

[vbotbuildovich]

/backport v23.2.x