cloud_storage: Remove stuck reader exception #12471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception is no longer used and therefore there is no need to handle it. The EOF condition is handled differently and the transition to the next segment can no longer get stuck because the reader caches the base_offset of the next segment.
andijcr
reviewed
Jul 26, 2023
src/v/ssx/task_local_ptr.h
Outdated
|
|
||
| template<class... Args> | ||
| explicit task_local(std::in_place_t, Args... args) | ||
| : _val(std::in_place, args...) |
There was a problem hiding this comment.
should be Args&&... args and std::forward(args)...
Lazin
force-pushed
the
pr/remove-stuck-reader-exception
branch
from
978649c
to
76f4dc9
Compare
Add c-tor overload that takes std::in_place_t and list of parameters for the underlying type.
Lazin
force-pushed
the
pr/remove-stuck-reader-exception
branch
from
76f4dc9
to
3695911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused exception and the code that handles it. This PR also includes some followup changes from previous PR:
remote_partitionusewith_manifestto callinitialize_reader_stateto avoid potential race condition.task_localadd new c-tor that acceptsstd::in_place_t+ list of parameters to construct underlying value.Backports Required
Release Notes