Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.1.x] txns: fix describe producers api to return correct last timestamp #12436

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[v23.1.x] txns: fix describe producers api to return correct last timestamp #12436

merged 1 commit into from
Aug 30, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #12285
Fixes: #12435,

@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Jul 24, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jul 24, 2023
@rystsov
Copy link
Contributor

rystsov commented Jul 31, 2023

A failure is irrelevant: a failing test (test_timequery_with_local_gc) doesn't use the changed api

@rystsov rystsov marked this pull request as ready for review July 31, 2023 21:51
@rystsov
Copy link
Contributor

rystsov commented Jul 31, 2023

/ci-repeat 1
dt-repeat=5

@piyushredpanda piyushredpanda modified the milestones: v23.1.x-next, v23.1.17 Aug 24, 2023
@rystsov
Copy link
Contributor

rystsov commented Aug 29, 2023 •
edited
Loading

All hanging builds have hanging "SegmentMsTest.test_segment_rolling" tests in common and this PR's changes can't be on its hot path so the failures must be irrelevant. Although I don't understand why it affects only this PR 🤷

Rebased and triggered a rebuild to see if it was a fluke or has been already fixed.

@rystsov rystsov force-pushed the backport-pr-12285-v23.1.x-67 branch from 8823c8b to 4c8e939 Compare August 29, 2023 21:45
@rystsov
Copy link
Contributor

rystsov commented Aug 29, 2023

/ci-repeat 1
dt-repeat=5

@rystsov
Copy link
Contributor

rystsov commented Aug 30, 2023

/ci-repeat 5
dt-repeat=1

@rystsov
Copy link
Contributor

rystsov commented Aug 30, 2023

looks like environment glitch: https://buildkite.com/redpanda/redpanda/builds/36014

Error response from daemon: Head "https://registry-1.docker.io/v2/minio/minio/manifests/RELEASE.2023-01-25T00-19-54Z": received unexpected HTTP status: 503 Service Unavailable

task:
 Failed to run task "rp:run-ducktape-tests": task: Failed to run task 
"rp:init-ducktape-containers": task: Failed to run task 
"rp:start-compose-cluster": exit status 18

the only substantial issue is a returned issue (but this is an older branch so it's fine): #12678

restarting the ci run to bypass the glitch

@rystsov
Copy link
Contributor

rystsov commented Aug 30, 2023

/ci-repeat 5
dt-repeat=1

@rystsov rystsov merged commit 268f3cf into redpanda-data:v23.1.x Aug 30, 2023
7 checks passed
@BenPope BenPope mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@bharathv bharathv Awaiting requested review from bharathv

Assignees

@rystsov rystsov

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @rystsov @BenPope @piyushredpanda