Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.3.x] c/rm_stm: fixed returning incorrect max_collectible_offset #12191

Commits on Jul 18, 2023

  1. c/rm_stm: fixed returning incorrect max_collectible_offset

    An off by one error in `rm_stm::max_collectible_offset` may lead to
    situation in which an stm couldn't continue. If `max_collectible_offset`
    returned last offset in the segment it may lead to the situation in
    which the whole segment was evicted before its last entry was applied.
    As the `max_collectible_offset` was returning `last_stable_offset` which
    indicates the offset for which all _previous_ offsets are decided (has
    no pending transactions and have been committed). In rare cases it may
    lead to situation where a segment ending at offset `n` was removed even
    though only `n - 1` was decided.
    
    Signed-off-by: Michal Maslanka <[email protected]>
    (cherry picked from commit 70541df)
    mmaslankaprv authored and vbotbuildovich committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7d89e17 View commit details
    Browse the repository at this point in the history