txns: fix list txns failure when it's used before find_coordinator #12116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
previously approved these changes
Jul 20, 2023
find_coordinator creates txn coordinator's topic when it's used for the first time. list txns api expects the topic to be already created so it used to fail when the api was invoked before find_coordinator. Fixed the problem by creating the topic on the first list txns call. fixes redpanda-data#11947
bharathv
reviewed
Aug 1, 2023
| @@ -316,7 +351,8 @@ ss::future<bool> tx_registry_frontend::try_create_tx_topic() { | |||
| return _controller->get_topics_frontend() | |||
| .local() | |||
| .autocreate_topics( | |||
| {std::move(topic)}, config::shard_local_cfg().create_topic_timeout_ms()) | |||
| {std::move(topic)}, | |||
| config::shard_local_cfg().create_topic_timeout_ms() * partitions_amount) | |||
There was a problem hiding this comment.
q: whats the rationale behind * partitions_amount part?
There was a problem hiding this comment.
create_topic_timeout_ms is too small to create 50 partitions in the ci environment. before it was use to create a single partition, * partitions_amount is the proportional increase. it's a bit meh but imho good enough, at least for the fix.
bharathv
approved these changes
Aug 2, 2023
|
/backport v23.1.x |
|
Failed to run cherry-pick command. I executed the commands below: |
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_coordinatorcreates txn coordinator's topic when it's used for the first time.list_transactionsapi expects the topic to be already created so it used to fail when the api was invoked beforefind_coordinator. Fixed the problem by creating the topic on the first list txns call too.Fixes #11947
Backports Required
Release Notes