admin_server/get_partition: Avoid oversized allocation #11824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid oversized allocation by: * Collecting summaries into a fragmented_vector * Streaming the vector to an output_stream The overload of `ss::json::json_return_type` that provides an `ss::output_stream` requires a `std::function`, which is required to be copyable, so wrap the `fragmented_vector` in a simple container wrapper that holds the container by `ss::lw_shared_ptr`. Another optimisation is moving rather than copying during accumulation. Fixes redpanda-data#11674 Signed-off-by: Ben Pope <[email protected]>
|
/cdt |
The oversized allocs in this test run are:
There's another one: |
|
On a roll, @BenPope -- thank you! |
@BenPope does this comment mean the PR isn't ready for review, or is the new over sized allocation something you turned into a different ticket to look into? |
No, I'm just noting an oversized alloc iin the test that hasn't got a ticket yet. |
michael-redpanda
approved these changes
Jul 6, 2023
Comment on lines
+146
to
+160
| template<typename C> | ||
| class lw_shared_container { | ||
| public: | ||
| using iterator = C::iterator; | ||
| using value_type = C::value_type; | ||
|
|
||
| explicit lw_shared_container(C&& c) | ||
| : c_{ss::make_lw_shared<C>(std::move(c))} {} | ||
|
|
||
| iterator begin() const { return c_->begin(); } | ||
| iterator end() const { return c_->end(); } | ||
|
|
||
| private: | ||
| ss::lw_shared_ptr<C> c_; | ||
| }; |
There was a problem hiding this comment.
nit: should this be in some utility folder somewhere? Could this be useful for other refactoring situations?
There was a problem hiding this comment.
I was wondering that; I haven't seen anything similar anywhere. I expect it will be useful again in this file, but perhaps also pandaproxy/rest. It can be moved later, I guess.
|
/backport v23.1.x |
|
Failed to run cherry-pick command. I executed the commands below: |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid oversized allocation by:
fragmented_vectorss::output_streamThe overload of
ss::json::json_return_typethat provides anss::output_streamrequires astd::function, which is required to be copyable, so wrap thefragmented_vectorin a simple container wrapper that holds the container byss::lw_shared_ptr.Another optimisation is moving rather than copying during accumulation.
Fixes #11674
Backports Required
Release Notes
Improvements