Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counts rebalancing simulation test problems #11622

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Fix counts rebalancing simulation test problems #11622

merged 3 commits into from
Jun 23, 2023

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Jun 22, 2023

  • Fix even topic partition distribution check - expect variance to be proportional to sqrt(expected)
  • Fix node disk sizes (prevent disk overflow on target nodes)

Fixes #11538

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

@ztlpn
c/pb_simulator: fix even topic distribution check
bcf2487 
Previously, we assumed that variance in topic replicas distribution is
proportional to number of replicas. This gives variance that is too
small for small partition counts and too large for large ones. Expect
that the variance is proportional to sqrt(number of replicas) instead.
@ztlpn
c/pb_simulator: print replica map in case of validation failure
0a47342
@ztlpn
c/pb_simulator: fix node disk sizes in counts rebalancing test
0300b50 
Previously, newly added nodes were added with disks that sometimes
overflowed. This led to unexpected partition counts skew.
@bharathv
Copy link
Contributor

Test failure looks related.

@ztlpn
Copy link
Contributor Author

ztlpn commented Jun 23, 2023

test failures are known:

Test failure looks related.

cluster_replicas_rebalancing_tests_rpfixture is an old test, so the failure is unrelated to this PR. I'll need to look into that too though.

@ztlpn ztlpn merged commit 6b18cb6 into redpanda-data:dev Jun 23, 2023
@ztlpn ztlpn deleted the fix-11538 branch November 27, 2023 13:57
@shane-runsafe shane-runsafe mentioned this pull request May 13, 2024
Open
This was referenced Oct 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathv bharathv bharathv approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure in partition_balancer_simulator_test_rpunit.test_counts_rebalancing
2 participants
@ztlpn @bharathv